Static on macosx #4332
Draft
Static on macosx #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laytan
reviewed
Oct 2, 2024
| link_command_line = gb_string_appendc(link_command_line, " -Wno-unused-command-line-argument "); | ||
| link_command_line = gb_string_append_fmt(link_command_line, " -o \"%.*s\" ", LIT(output_filename)); | ||
|
|
||
| link_command_line = gb_string_appendc(link_command_line, object_files); |
There was a problem hiding this comment.
why did you move the object files from before the -o to after it?
| @@ -631,7 +627,7 @@ gb_internal i32 linker_stage(LinkerData *gen) { | |||
| link_settings = gb_string_append_fmt(link_settings, "-mmacosx-version-min=%.*s ", LIT(build_context.minimum_os_version_string)); | |||
| } | |||
|
|
|||
| if (build_context.build_mode != BuildMode_DynamicLibrary) { | |||
| if (build_context.build_mode != BuildMode_DynamicLibrary && build_context.build_mode != BuildMode_StaticLibrary) { | |||
There was a problem hiding this comment.
This does not look needed? link_settings isn't used when you do a static library from what I can tell.
| static_link_command_line = gb_string_appendc(static_link_command_line, object_files); | ||
| return system_exec_command_line_app("libtool", static_link_command_line); | ||
| } else { | ||
| compiler_error("-build-mode:static on Linux and similar targets"); |
There was a problem hiding this comment.
Suggested change
| compiler_error("-build-mode:static on Linux and similar targets"); | |
| compiler_error("TODO: -build-mode:static on this target"); |
Looks like I need to call "dsymutil <your_program>" somehow, but it says that the object files don't have debug data. I'll look into it later However I have no problem debugging in my example code, so maybe it isn't a thing for static libraries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested that this works with the iPhone simulator
Basically just call "libtool -static" on the object files
An unfortunate thing I have to do when linking to a static odin library, is to call runtime._startup_runtime()