Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

References remain to main egeria directories #8

Open
planetf1 opened this issue Dec 14, 2020 · 26 comments
Open

References remain to main egeria directories #8

planetf1 opened this issue Dec 14, 2020 · 26 comments
Labels

Comments

@planetf1
Copy link
Member

The new project no longer is in a 'presentation-server' directory tree as it was when the code was in base egeria, yet
there remain references to this path in

routes.js
.env.sample
getAxiosAssistance.js

cc: @davidradl

Additionally the documentation for Dino, Rex & Tex refer to relative paths for .md doc files
components/Dino/README.md
components/RepositoryExplorer/README.md
components/TypeExplorer/README.md

cc: @grahamwallis

It probably makes sense I work on my docker config changes + docker build for this repo and let you fix these up and test :-)

@grahamwallis
Copy link
Contributor

I have done a search and can't find these references. Where did you see them?

@planetf1
Copy link
Member Author

This are my search results, up to date with main
Screenshot 2020-12-15 at 13 41 47

@planetf1
Copy link
Member Author

planetf1 commented Dec 15, 2020

Just realised - my bad on a few of the hits which had an embedded subdir (not checked in - finger trouble migrating). = 1st and 4th, but they weren't the ones relating to path in any case, just a name ref

@planetf1
Copy link
Member Author

They are present in the original code in egeria, and the content I ported over

@grahamwallis
Copy link
Contributor

Cool thanks - I had read your original comment round the other way. Was looking for those as the refs - rather than the files containing the relative refs. Got it now. Will sort.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@planetf1
Copy link
Member Author

planetf1 commented Apr 8, 2021

There are still bad references in the documentation to 'presentation-server'. reopening

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@planetf1
Copy link
Member Author

reopening - issues still present

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@planetf1
Copy link
Member Author

Still bad links, but probably worth updating after the docs are migrated to the new docs repository

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@davidradl
Copy link
Member

@planetf1 it looks like this is fixed. I have left the old react ui docs around for now. But the main readme points to the egeria-docs repo where I have documented react ui

@planetf1
Copy link
Member Author

I can only see 3 minor references left in the readmes, which have old relative links assuming the code is in egeria:
Screenshot 2022-01-11 at 09 01 21

@planetf1
Copy link
Member Author

planetf1 commented Jan 11, 2022

These three readmes contain various other bad references too -- the above was just an example from the search, but it's the same files. Agree, the other areas are fixed

@planetf1
Copy link
Member Author

found a few more refs - search for 'admin-services/docs'

Overview.md, prereqs.md, setup.md

davidradl added a commit that referenced this issue Jan 11, 2022
@davidradl
Copy link
Member

I have removed the old docs - so there should not be any references now . @planetf1 Can you confirm i can close?

@planetf1
Copy link
Member Author

Still seeing bad refs in

cra-client/src/components/RepositoryExplorer (not sure on intent, but dangling links)
design/glossary-author/README.md (link to bad img)

davidradl added a commit that referenced this issue Jan 20, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@davidradl
Copy link
Member

@planetf1 it looks like I put in an pr to address you remaining concerns - can we close?

@planetf1
Copy link
Member Author

The old readmes still have references ie
odpi/egeria-connector-hivemetastore#142 refers to /admin-services/docs/ - search for '../..' in *.md

To find other bad links, you may want to setup the link checker - see https://github.com/odpi/egeria/blob/main/.github/workflows/linkcheck.yml

it has an option fail:false which can be set to true to cause the pr to fail if bad links found. May be the easiest way to validate

@davidradl davidradl removed their assignment Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants