-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to the test matrix #814
Comments
Per the Python 3.12 release notes, |
The testing GH Action reports, "from six.moves.urllib_parse import urlsplit, urlunsplit" only for Python 3.12. EDIT: see #816 for the above effort. |
/Users/runner/work/ipwb/ipwb/ipwb/util.py:27: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
|
|
The main reason for this check was to send a communicate with the IPFS daemon differently if its version was < 0.4.10, which is far from supported by ipwb. Regardless, it is useful to have this logic to check for a supported version of the daemon to ensure commands from ipwb will be processed predictably. |
An alternative can be had in the packaging external module.
|
Another substitute from replay.py is the need for replacing:
with the equivalent from |
We likely don't need to assert the function with assert in the name. That might be the solution to the testing reporting a comparison with |
Released October 2, 2023 though its availability in the GitHub Actions test suite is TBD.
The text was updated successfully, but these errors were encountered: