Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midi sanitization #85

Open
oggy22 opened this issue Feb 9, 2020 · 0 comments
Open

Midi sanitization #85

oggy22 opened this issue Feb 9, 2020 · 0 comments

Comments

@oggy22
Copy link
Owner

oggy22 commented Feb 9, 2020

The midi files found on internet may contain number of inaccuracies. These inaccuracies manifest mostly as inaccurate durations of notes. For example note of duration 33 should last 30 ticks which leads that adjecent notes overlap in time whereas they should not.

The process of correcting the midi files is SANITIZATION.

This item is two-piece work:

  1. Sanitize all the midi files currently in use and tests
  2. Make the midi-load routine check for sanitization and fail if it is not sanitized.
oggy22 added a commit that referenced this issue Feb 9, 2020
@oggy22
Progress on #85:
fad177f 
- Sanitized all Bach inventions
- Midi load routine with checks for weird small durations based on common divisor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oggy22