Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Attention and other extensions #28

Open
loganbruns opened this issue Jun 19, 2019 · 2 comments
Open

Self-Attention and other extensions #28

loganbruns opened this issue Jun 19, 2019 · 2 comments

Comments

@loganbruns
Copy link

@ogroth, as mentioned in #27 I've found it useful to add self-attention and also some additional training options to limit the amount of data used for training. Also a simple test script. Would you please take a look at my branch and give me an idea of what parts you might consider including and I'll create a pull request with that subset?

master...loganbruns:sa_gqn

Thanks,
logan

@ogroth
Copy link
Owner

ogroth commented Jun 21, 2019

The self-attention encoder you've added in gqn_encoder.py looks neat. Can you send me a pull request for that on the attention_encoder branch?

@loganbruns
Copy link
Author

@ogroth, thanks. I created a pull request with just the self-attention encoder in this pull request:

#30

I was wondering if you might be interested in a separate pull request against master with the limited training flags, --train_subset, from the branch above as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants