Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta SDK.NET 8.1.5 Triggers a transient dependency breaking issue #745

Open
rcollette opened this issue Sep 18, 2024 · 4 comments
Open

Okta SDK.NET 8.1.5 Triggers a transient dependency breaking issue #745

rcollette opened this issue Sep 18, 2024 · 4 comments
Labels

Comments

@rcollette
Copy link

rcollette commented Sep 18, 2024

Describe the bug?

This is not a bug per-se, but existing applications can experience a breaking change to their application behavior, due to a mismatch in dependency versions needed by Microsoft.AspNetCore.Authentication.JwtBearer

I have documented the issue further in
dotnet/aspnetcore#57940

The normal list of dependencies for Microsoft.AspNetCore.Authentication.JwtBearer are shown here
image

When importing just the two updated versions of packages that were included with the 8.1.5 release, there is now a mismatch between the cooperating packages

image

To fix two additional packages must be referenced in the project.

    <PackageReference Include="Microsoft.IdentityModel.Protocols" Version="8.0.2" />
    <PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.0.2" />

What is expected to happen?

Documentation of this library may want to call out, at least on a temporary basis, the need to import additional dependencies to ensure JWTBearer token authentication does not break, if being used.

What is the actual behavior?

JWTBearer authentication fails at runtime with

IDX10500: Signature validation failed. No security keys were provided to validate the signature

Reproduction Steps?

The description is sufficient since there isn't an actual bug in the SDK code.

Additional Information?

No response

.NET Version

8.0.401

SDK Version

8.1.5

OS version

No response

@rcollette rcollette added the bug label Sep 18, 2024
@bryanapellanes-okta
Copy link
Contributor

@rcollette Thanks for bringing this to our attention. I've entered an internal issue for tracking and prioritization: OKTA-812145

@rcollette
Copy link
Author

Related to previous issue #736

@NoahStolk
Copy link

This is not the first time this has happened. I reported the same issue for 7.0.4 as well: #692 & #690

This is the issue: https://github.com/okta/okta-sdk-dotnet/pull/744/files#diff-697ea5e447b22623a833c3c071533ce619c00014b2d0362b1496ffa2df3787f1

This is a breaking change which goes against Okta's own versioning policy. This page is listed in the README.

We:
Increase the patch version for bug fixes, security fixes, and code documentation. Backwards compatible and no breaking changes.
Increase the minor version for new features and additions to the library's interface. Backwards compatible and no breaking changes.
Increase the major version for breaking changes to the library's interface or breaking changes to behavior.

Why couldn't this be released as v9? Please revert this change and release it as 8.1.6. We will be banning version 8.1.5 as it breaks all of our applications.

@chekm8
Copy link

chekm8 commented Nov 12, 2024

I just ran into this issue today, I have an .Net 8 project referencing the Okta.AspNetCore package and I was able to consume access_token's fine. I added a reference to the latest Okta.Sdk (v9.0.0) and immediately started to get a invalid_token, "The signature key was not found" error. I didn't even implement any code to consume the SDK yet.

Added a direct reference to the following packages resolved the issue:

<PackageReference Include="Microsoft.IdentityModel.Protocols" Version="8.2.0" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.2.0" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants