Where do the highlights for C come from? #226
-
|
They don't seem to match the VSCode theme. For instance, macros seem to have the same color as functions for me. Wanted to know if this was intended behavior or not. Otherwise I will customize them on my side. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 8 replies
-
|
Must be coming from Tree-sitter as there are no custom C highlights in the plugin. If you share some code I'll be happy to take a look at the highlighting |
Beta Was this translation helpful? Give feedback.
-
|
Neovim:
VSCode:
I am a heavy C user FWIW, so I can definitely help match C up with VSCode if I know where to look! |
Beta Was this translation helpful? Give feedback.
-
#include <stddef.h>
#include <stdio.h>
#define HELLO_WORLD "hello world"
int
main(int argc, char **argv)
{
printf("%s: %p", HELLO_WORLD, NULL);
if (NULL) {
return 0;
} else {
return 1;
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Check out the CONTRIBUTING.md file. Would welcome a PR for this! I typically ask ChatGPT to generate an example file containing common syntax examples and then paste that into VS Code and Neovim to use as a template to work from. |
Beta Was this translation helpful? Give feedback.
-
|
Looks very easy to get started. Hopefully I will come up with a PR soon! |
Beta Was this translation helpful? Give feedback.
-
|
@olimorris I was wondering what the stance on the project is when a theme diverges from VSCode. Is it a bug if they don't match? I was just looking at a Markdown file which is colored quite differently from VSCode. |
Beta Was this translation helpful? Give feedback.
-
|
Really good question. Generally speaking, I try and stay as close to the VS Code theme as possible but Markdown is currently an exception. I can't recall when it diverged so much but it's quite a bit different now. It feels a bit strong to call the divergence a bug but technically it is so would be open to any pull requests (and for Markdown I will fix that myself). The theme makes it easy for users to apply their own custom highlights anyway. |
Beta Was this translation helpful? Give feedback.
-
|
Very true. Just thought I would upstream any changes if it is the goal to match. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah please do! If you could provide before and after screenshots in any PRs that would be awesome |
Beta Was this translation helpful? Give feedback.
-
|
Cool. Are you still going to do the Markdown updates? I have noticed C++ files vary too. Python imports are also uncolored. I can try to get to both of those some time soon. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah I'll take the markdown ones as I'll provide a guide for users to revert to the previous colors. But feel free to get started on any of the others. Note...they may require some custom Tree-sitter queries |
Beta Was this translation helpful? Give feedback.
Really good question. Generally speaking, I try and stay as close to the VS Code theme as possible but Markdown is currently an exception. I can't recall when it diverged so much but it's quite a bit different now.
It feels a bit strong to call the divergence a bug but technically it is so would be open to any pull requests (and for Markdown I will fix that myself). The theme makes it easy for users to apply their own custom highlights anyway.