Should we color global variables in lua differently than regular variables

[tristan957]

Here is the output of :Inspect when hovering the vim global variable.

Treesitter
  - @variable.lua links to @variable lua

Semantic Tokens
  - @lsp.type.variable.lua links to @variable priority: 125
  - @lsp.mod.global.lua links to @lsp priority: 126
  - @lsp.typemod.variable.global.lua links to @lsp priority: 127

Extmarks
  - LspReferenceRead links to LspReferenceText vim_lsp_references
  - LspReferenceRead links to LspReferenceText vim_lsp_references

This would seemingly be a departure from the VSCode theme, best I can tell, but I think it would help with readability. This would be inline with how we highlight string, table, io, etc.

[olimorris]

Can you share some screenshots?

[olimorris]

Have you got any settings applied in VS Code? Mine looks like:

[tristan957]

That is also how it looks in vscode for me.

This would seemingly be a departure from the VSCode theme

[olimorris]

Sorry I missed your comment earlier. As this deviates from the VS Code theme I'll keep it out.

Playing around though, setting a custom highlight of ["@lsp.typemod.variable.global.lua"] = { fg = "${yellow}" } gives:

Otherwise, the only option would be some custom tree-sitter queries to pick out variables like "vim" etc.

[olimorris]

@tristan957 if you have a list of keywords that you think should be highlighted, I'll be happy to put a tree-sitter query in the plugin that detects these because I do agree that it helps readability and breaks up the chain of red

[tristan957]

No, it's all good. I'll just keep this highlight locally then.