Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we provide a way to test the package end to end? #103

Open
praveen-elastic opened this issue Aug 16, 2022 · 1 comment
Open

Can we provide a way to test the package end to end? #103

praveen-elastic opened this issue Aug 16, 2022 · 1 comment
Labels

Comments

@praveen-elastic
Copy link

Great work with the repository, just a small request to add support for end-to-end testing. Like other open-source projects out there, can we get the endpoint for the server from OS so that the developer can overwrite such environment variable at the time of end-to-end testing?

@omarryhan
Copy link
Owner

Hi thanks!

Yes, I'm open to it, I remember we used to have some end to end tests before, but I think we're no longer running them. In the Tox config file, you can find a client id and client secret fields, this was before we added support for service accounts.

I'm happy to accept a PR that implements e2e testing. Lmk if you need any further guidance, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants