Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: Inheritance class AiohttpSession from ClientSession is discouraged #90

Open
RomeoDespres opened this issue Mar 10, 2022 · 1 comment
Labels

Comments

@RomeoDespres
Copy link

Importing aiogoogle raises a DeprecationWarning. Usually we don't see it because Python filters it out, however when running tests with pytest it does show up and kinda messes up the output.

It's not really a big deal but I just thought it was worth flagging. Otherwise the lib is great!

You can see it by running the following:

$ python -Wd -c "import aiogoogle"
C:\Python39\lib\abc.py:85: DeprecationWarning: Inheritance class AiohttpSession from ClientSession is discouraged
  cls = super().__new__(mcls, name, bases, namespace, **kwargs)

aiogoogle: 3.2.1
Python: 3.9.2
OS: Windows 10

@omarryhan
Copy link
Owner

Hey, thanks for raising the issue!

It's quite an annoying warning. It existed since the time I wrote this lib.

Unfortunately, I don't know how to disable it. Also, I don't think that the way we're doing inheritence should be worthy of this warning.

So, if you can find a way to disable this warning, I will happily merge ur PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants