Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inset bugfixes #603

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Inset bugfixes #603

merged 4 commits into from
Dec 9, 2024

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Nov 28, 2024

Fixes #601
PR contains 2 bug-fixes and 1 minor tweak (improvement)?

Test bug-fix 1:

  • Select a panel and use the "Inset" button to create an Inset
  • Copy and paste the newly created Inset panel to duplicate it
  • Now delete ONE of the 2 inset panels. The inset ROI shouldn't be deleted.
  • If you delete the other inset panel the inset ROI should be deleted as before.

Test bug-fix 2:

  • Select a panel and use the "Inset" button to create an Inset
  • Select both the original panel and the new inset panel.
  • Copy and Paste to duplicate the pair of panels
  • Repeat the copy and paste to duplicate the 2 panels again.
  • Check that each inset ROI is only "linked" to it's corresponding inset panel (that was duplicated at the same time).
Screenshot 2024-11-28 at 21 59 52

Minor change:

  • I've made the default panel border to be Yellow (instead of White) and 5px think (instead of 2). This change (particularly the colour) is to avoid possible confusion when a user click on the "Show Border" button and sees no change because the default white border is not visible against the white figure background. Also I found that I prefer 5px thick as it improves visibility of the border and is a better default value?

@will-moore
Copy link
Member Author

@Rdornier I wonder if you could have a look at these 2 bug fixes and 1 possible improvement? (see details above). Thanks!

I think that once this and #592 is merged, we should get the release out since we have a good amount of new stuff now (see changelog at #602).
I'll have a look at your ROI labels ASAP, and can do another release with that when it's ready. Thx

@Rdornier
Copy link
Contributor

@will-moore Sure !

  • Bug 1 : OK
  • Improvement : OK
  • Bug 2 : OK to some extend. If I do copy > paste and then copy > paste, then it is working properly. But If do copy > paste > paste, then the ROIs of the two copied panels are linked together to the last copied ROIs (gray lines). If I move the central panel, nothing append on the central ROI

image

I think that once this and #592 is merged, we should get the release out since we have a good amount of new stuff now (see changelog at #602).

Yes, I think it is good idea

I'll have a look at your ROI labels ASAP, and can do another release with that when it's ready

Sounds good 👍

@will-moore
Copy link
Member Author

@Rdornier Thanks for catching that! Strange behaviour due to the clipboard data being a shallow copy for new panels. I think it's fixed with that commit above.

@Rdornier
Copy link
Contributor

Yes, it's fixed. 👍

@will-moore will-moore merged commit 7a57378 into ome:master Dec 9, 2024
1 check passed
@jburel jburel mentioned this pull request Dec 12, 2024
will-moore added a commit to will-moore/figure that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs with Inset workflow
2 participants