-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and display non-zero returncode from scripts #474
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
803f18c
Detect and display non-zero returncode from scripts
will-moore bd9f57d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f5384a2
Add returncode to error message
will-moore f4c0fcd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1879956
flake8 fix
will-moore 8081fa7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c9a586d
Revert Comment change to avoid merge conflict
will-moore c88fdf7
Merge remote-tracking branch 'origin/master' into script_failure_hand…
will-moore 659d4c5
Always use status:'finished' when done, even if error
will-moore 760da8e
Use 'returncode' instead of 'failure' and 'error'
will-moore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if a script first set a message output via
client.setOutput
and then terminate with a non-zero return code?Should we handle this use case and respect the message sent by the script and use this as the default error is unset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbesson Just returning to this... In my testing, if the script does
client.setOutput(....)
then generates some un-caught exception and terminates, the output is not passed on to the server. I don't see it in the code atomero-web/omeroweb/webclient/views.py
Line 3822 in d5e4f84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies - made a mistake in my
client.setOutput("Message"...)
. That is actually handled OK and is displayed in place of the error message:However, most scripts don't try to return a "Message" until the end, so it's likely that if a script fails with some uncaught exception then the "Message" won't have been set.