Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite kwargs in activities json #541

Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Mar 7, 2024

Reported at ome/omero-figure#545

This fixes a bug introduced in #474, the kwargs parameter overwrites the kwargs from the function def activities(request, conn=None, **kwargs): causing various issues.

E.g. the detection of json template fails at

if "template" in kwargs and kwargs["template"] == "json":
so the format of the JSON returned to OMERO.figure is broken, as reported above.

To test:

  • Open the developer Console in your browser
  • Export a figure from OMERO.figure
  • Check that the export completes and the Download button is shown with no errors in the Console

@will-moore will-moore added this to the 5.25.0 milestone Mar 7, 2024
@will-moore will-moore requested a review from knabar March 7, 2024 17:37
Copy link
Member

@knabar knabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes the issue with PathViewer

@knabar knabar merged commit 99aebd2 into ome:master Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants