Removal of python-future compatibility

[sbesson]

See also ome/omero-py#390

This PR reviews and cleans up all the code ensuring Python 2/3 compatibility including:

• all imports of future and past modules
• all checks of sys.version
• all redundant imports of builtins

[jburel]

builtins still present in clitest/test_tag.py
Also in OmeroFS/test/drivers.py

[sbesson]

For OMERO.fs, I don't think it's an import

openmicroscopy/components/tools/OmeroFS/test/drivers.py

Line 232 in 8398c91

filesets = eval(data, {"__builtins__": None}, {})

For the CLI tag test, I left the import as the input method is monkeypatched as part of the test

openmicroscopy/components/tools/OmeroPy/test/integration/clitest/test_tag.py

Line 134 in 8398c91

monkeypatch.setattr(builtins, "input", mock_input)

[jburel]

The changes look good
One thing I noticed is that we do not test various Python version. This is only tested with Python 3.10
We will need to modify the action https://github.com/ome/action-ice/blob/main/action.yml in order to support other Python version

[sbesson]

Which use case are we trying to solve here? To the best of my knowledge of the GitHub workflows are executing the tests so I am not even sure the Python Ice bindings are a requirements for building.

[jburel]

It is when you build the gateway.
Anyway I am doing some tests with various Python versions. I will push a commit

[jburel]

Building with 3.12 leads to

  File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/setuptools/_vendor/packaging/version.py", line 198, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
setuptools.extern.packaging.version.InvalidVersion: Invalid version: 'UNKNOWN-ice36'

see https://github.com/jburel/openmicroscopy/actions/runs/8302622326/job/22725266554

[sbesson]

Thanks @jburel, the UNKNOWN is likely related to the tag not being pulled. Independently of this, I have certainly seen similar errors recently with modern Python versions. I think one of the issues is that setuptools 69.0.0 now enforces strict compliance with PEP440 and we know the omero_version set via the build system and consumed in the various components/tools Python components inhttps://github.com/ome/openmicroscopy/blob/8398c91cfbb1f0e7a0ac1be24898132799639e3c/components/tools/python.xml#L15-L19 is not compliant.

components/tools probably needs to be reviewed and simplified (or extracted). Immediately two possible workarounds are:

• pin setuptools<69 when install the requirements
• set export NOPYTHON=1 i.e. skip the building of the Python components

[jburel]

@sbesson I have pushed commits to your PR so we run the build with Python 3.10, 3.11 an 3.12