Update oneDAL PCA infer method #2410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alam/oneDAL into dev/extend_pca_model
| } | ||
|
|
||
| const auto res_array = res_nd.flatten(queue, { gemm_event }); | ||
| const auto res_table = homogen_table::wrap(res_array, row_count, component_count); | ||
| return result_t{}.set_transformed_data(res_table); | ||
| } | ||
|
|
There was a problem hiding this comment.
it seems to me that our bazel tests almost do not cover infer for pca, might be a good time to add them
md-shafiul-alam
requested review from
Alexsandruss,
samir-nasibli and
KulikovNikita
as code owners
| Float(1.0), | ||
| Float(0.0), | ||
| { mean_center_event }); | ||
| gemm_event.wait_and_throw(); |
There was a problem hiding this comment.
WHat is the point of waiting for the event here?
| @@ -51,6 +51,98 @@ sycl::event means(sycl::queue& q, | |||
| }); | |||
| } | |||
|
|
|||
| // Subtract 1d array from 2d array elementwise | |||
| template <typename Float> | |||
| sycl::event elementwise_difference(sycl::queue& q, | |||
There was a problem hiding this comment.
Please use elementwise operations that are already present
|
|
||
| // SQRT of 1d array elementwise | ||
| template <typename Float> | ||
| sycl::event elementwise_sqrt(sycl::queue& q, |
|
|
||
| // Divide 2d array by 1d array elementwise | ||
| template <typename Float> | ||
| sycl::event elementwise_division(sycl::queue& q, |
|
How does this PR compare to #2573 ? |
2573 is an updated version of this. Closing this one as duplicate. |
|
Changes have been moved to #2573, closed as duplicate |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes are proposed to move some computations from python wrappers to oneDAL to improve performance of python libraries.
Changes proposed in this pull request: