Migrate make to ICX/ICPX for Windows #2712
Conversation
Alexandr-Solovev
changed the title
|
/intelci: run |
|
/intelci: run |
once ready i would say? |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
@Alexsandruss any other comments, it doesn't affect scikit-learn-intelex due to it still uses icc/icl as default |
|
/intelci: run |
|
Jobs with ICX as a build compiler: Linux: intel-ci.intel.com/ef65521e-d0d2-f199-b313-a4bf010d0e2e (builds passed) |
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
requested review from
Vika-F,
maria-Petrova and
bdmoore1
as code owners
|
/intelci: run |
There was a problem hiding this comment.
Assuming green CI.
@homksei could you please dismiss @Alexsandruss change request in case, since the comment is already addressed?
Description
In this pull request, we are migrating the project's default build system on Windows from the ICL to using ICX.
All changes are necessary to build oneDAL properly.
DAAL_EXPORTwas removed from some classes, due to correct dllexport build. In general just called functions should be marked as DAAL_EXPORT, and derived classes shouldn't. Most of the changes were done to have green CI.The concatenate operation
##works pretty strange and MKL function macros have been updated for it.[[maybe_unused]]is necessary for avoid compiler issues.The base version of C++ has been increased to C++17.