Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing oneDAL roles for contributors and maintainers #2916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

napetrov
Copy link
Contributor

Description

This is initial version of MAINTAINERS.md that define roles and list certain individuals in those roles.

Feedback and recommendations are welcome

@napetrov
Copy link
Contributor Author

@keeranroth @rakshithgb-fujitsu - please take a look on this. open for recommendations/suggestions

@keeranroth
Copy link
Contributor

@napetrov thanks for the mention, and I'm happy to be down as a code owner for the RISC-V part of the code base, with the caveats listed below.

The wording is good, except I'm always hesitant about putting time commitments on roles, although it would be nice to show that some effort is expected here. In general, as long as a person is fulfilling their responsibilities, then the time commitment doesn't play too much of a role. Using me as an example, for the RISC-V part, I am happy to be down as a code owner, and will have a quick turnaround on code review. However, that won't take 25% of my time, for what is a relatively new and not yet widely used part of the oneDAL project. I can make fixes to broken pipelines, but turnaround might be on the order of a week or two, depending on other responsibilities. As RISC-V usage and contributions pick up, it might be good to come back to this and choose a more active member of the community as a code owner.

So, I suggest that the bullet point around the time requirement be taken out. For the code owners in RISC-V section, I'm happy to be listed, as long as the caveat mentioned above is acceptable. What do you think?

@rakshithgb-fujitsu
Copy link
Contributor

I agree with Keeran on this; as the oneDAL community expands, more individuals will naturally take on roles as code owners and maintainers. Implementing a time requirement isn’t a beneficial approach.

@napetrov
Copy link
Contributor Author

@keeranroth @rakshithgb-fujitsu Thanks for feedback! cleaned up those lines on time commitments,

Copy link
Contributor

@keeranroth keeranroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @napetrov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants