[fix] correct Nightly-build, clean up ci files. #2920
+38
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icfaust
requested review from
Alexsandruss,
napetrov,
homksei,
ahuber21 and
ethanglaser
as code owners
| set URL=%1 | ||
| set COMPONENTS=%2 | ||
| if "%2"=="" (set COMPONENTS=default) else (set COMPONENTS=%2) |
There was a problem hiding this comment.
where is set the default components of toolkit?
| - name: Install DPC++ | ||
| shell: cmd | ||
| run: | | ||
| call .\.ci\scripts\install_windows.bat ${{ env.WINDOWS_BASEKIT_URL }} ${{ env.WINDOWS_ALL_COMPONENTS }} | ||
| call .\.ci\scripts\install_windows.bat ${{ env.WINDOWS_BASEKIT_URL }} ${{ env.WINDOWS_ALL_COMPONENTS }} .\oneapi\ |
There was a problem hiding this comment.
can you also as part of this work add variable for control version instead of hardcoding it
https://github.com/oneapi-src/oneDAL/pull/2920/files#diff-2ee59052448a421cff47b6ee98f786b57f3012d9f9132d37b9bde685a6266166R28
| - name: Install DPC++ | ||
| shell: cmd | ||
| run: | | ||
| call .\.ci\scripts\install_windows.bat ${{ env.WINDOWS_BASEKIT_URL }} ${{ env.WINDOWS_ALL_COMPONENTS }} | ||
| call .\.ci\scripts\install_windows.bat ${{ env.WINDOWS_BASEKIT_URL }} ${{ env.WINDOWS_ALL_COMPONENTS }} .\oneapi\ |
There was a problem hiding this comment.
also, please update ci.yml file, because it also uses this install_windows.bat script
| set MKL_FPK_GPU_VERSION_LINE=2024.0.0 | ||
| call C:\temp\oneapi\compiler\latest\bin\sycl-ls.exe | ||
| call .\oneapi\setvars.bat | ||
| call .\oneapi\compiler\latest\bin\sycl-ls.exe |
There was a problem hiding this comment.
is it really necessary here? Its a general question
There was a problem hiding this comment.
the setvars yes, but the sycl ls isn't technically, just wanted to provide info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generally hard-coding complete directories in a CI runner is a no-no.
OpenCL runtime is necessary for windows dpc testing in sklearnex
clean up windows_build.bat and add alternate install directory
remove unnecessary files which have been duplicated
create an environment variable to minimize maintenance