[DFT] Add descriptor move constructor and assignment #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds dft::descriptor move constructor * Adds dft::descriptor move assignment * Adds basic tests for both * Notes that copy is not implemented
Rbiessy
reviewed
Jul 14, 2023
Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
Rbiessy
approved these changes
Jul 17, 2023
FMarno
approved these changes
Jul 17, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* [DFT] Add descriptor move constructor and assignment * Adds dft::descriptor move constructor * Adds dft::descriptor move assignment * Adds basic tests for both * Notes that copy is not implemented * Correct comment spelling error. Co-authored-by: Romain Biessy <romain.biessy@codeplay.com> --------- Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is paired with suggested changes to the oneMKL specification here for adding move to the
dft::descriptorclass.Checklist
All Submissions
dftTestLog_20230710_1354.txt