Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SparseBlas]Initial design of Sparse Coo data #496

Closed
wants to merge 1 commit into from

Conversation

abhilash1910
Copy link

@abhilash1910 abhilash1910 commented May 23, 2024

Description

Motivation

Currently from one of the priority app CUDA - SYCL migration perspective (CUDA-SYCL Task Force) (bitsandbytes) , there is a requirement to support COO format. Since currently the scope is through CSR, the code migration is routed through CSR pathway. However for an efficient migration of CUDA applications invoking COO, I propose a design for COO format. I have taken reference from the existing CSR implementation as most of the function args are similar. The current application requires cusparseCreateCoo api, and I had taken reference from this api invokation:

cusparseCreateCoo(cusparseSpMatDescr_t* spMatDescr, int64_t rows, int64_t cols, int64_t nnz, void* cooRowInd, void* cooColInd, void* cooValues, cusparseIndexType_t cooIdxType, cusparseIndexBase_t idxBase, cudaDataType valueType)

It would entail development of some COO auxiliary methods , getters ,aos and const variants in general. Since currently COO is not supported on iGPU yet , it would be nice to have this feature for future application migrations.
Tagging @Rbiessy from discussion.

@abhilash1910 abhilash1910 marked this pull request as draft May 23, 2024 08:45
@Rbiessy
Copy link
Contributor

Rbiessy commented May 23, 2024

Hello @abhilash1910, we have updated the specification for the sparse domain recently: uxlfoundation/oneAPI-spec#522. Among other changes this adds support for the COO format.
I am already working on updating the MKL backends to match the new API. I expect the PR will be in review sometime next week so I would rather not change the existing implementation. FYI I will start working on adding support for cuSPARSE after that.

@Rbiessy
Copy link
Contributor

Rbiessy commented May 30, 2024

I think this PR can be closed in favor of #500. Let me know @abhilash1910 whether this would work for you.

@abhilash1910
Copy link
Author

Thanks @Rbiessy , I will review shortly , in the meantime closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants