[DFT][Examples] Make the oneMKL DFT example consistent with the other domains #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
reviewed
Jun 20, 2024
Rbiessy
approved these changes
Jun 21, 2024
Make CMakeLists configuration for compile-time dft example similar to other domains. Add mklcpu+cufft example.
Update example README and fixing copyright year of new dft example mklcpu+cufft.
Update example output for compile-time and run-time example
This reverts commit 5015d2b.
mkrainiuk
approved these changes
Jun 25, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch updates the oneMKL DFT examples making them consistent with other domains. In particular, it removes the old split examples for mklcpu and mklgpu and it adds a new example that uses mklcpu and cuFFT backend, same backend combination used in other examples. It enables run-time example for mklcpu backend and it updates example README.
All Submissions
Do all unit tests pass locally? Attach a log.
dft_examples.txt
Have you formatted the code using clang-format?