[DFT] Corrections to FWD/BWD_STRIDES API #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Addresses spec deviations for API implementation * Improves run-time checks * Improves comments
5 tasks
raphael-egan
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Just a small suggestion about which I let you judge, @hjabird. Otherwise, I'm fine with the changes, provided the pending tests pass. Thank you!
|
Test logs:
|
Rbiessy
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the PR that introduced the FWD/BWD STRIDE API (#528), @raphael-egan provided some valuable feedback just as the PR was merged. This feedback included:
This PR aims to address these comments
Checklist
All Submissions