Adds warning message to CUDA + removes calls it die() in Hip

oneapi-src · Dec 15, 2023 · 01cd56d · 01cd56d
1 parent 1ed2107
commit 01cd56d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/source/adapters/cuda/command_buffer.cpp b/source/adapters/cuda/command_buffer.cpp
@@ -549,6 +549,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMPrefetchExp(
  // Get sync point and register the cuNode with it.
  *pSyncPoint =
  hCommandBuffer->AddSyncPoint(std::make_shared<CUgraphNode>(GraphNode));
+
+ setErrorMessage("Prefetch hint ignored and replaced with empty node as "
+ "prefetch is not supported by CUDA Graph backend",
+ UR_RESULT_SUCCESS);
+ Result = UR_RESULT_ERROR_ADAPTER_SPECIFIC;
  } catch (ur_result_t Err) {
  Result = Err;
  }
@@ -579,6 +584,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMAdviseExp(
  // Get sync point and register the cuNode with it.
  *pSyncPoint =
  hCommandBuffer->AddSyncPoint(std::make_shared<CUgraphNode>(GraphNode));
+
+ setErrorMessage("Memory advice ignored and replaced with empty node as "
+ "memory advice is not supported by CUDA Graph backend",
+ UR_RESULT_SUCCESS);
+ Result = UR_RESULT_ERROR_ADAPTER_SPECIFIC;
  } catch (ur_result_t Err) {
  Result = Err;
  }

diff --git a/source/adapters/hip/command_buffer.cpp b/source/adapters/hip/command_buffer.cpp
@@ -127,17 +127,13 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMPrefetchExp(
  ur_usm_migration_flags_t, uint32_t,
  const ur_exp_command_buffer_sync_point_t *,
  ur_exp_command_buffer_sync_point_t *) {
- detail::ur::die("Experimental Command-buffer feature is not "
- "implemented for HIP adapter.");
  return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
 }
 
 UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMAdviseExp(
  ur_exp_command_buffer_handle_t, const void *, size_t, ur_usm_advice_flags_t,
  uint32_t, const ur_exp_command_buffer_sync_point_t *,
  ur_exp_command_buffer_sync_point_t *) {
- detail::ur::die("Experimental Command-buffer feature is not "
- "implemented for HIP adapter.");
  return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
 }