From 01cd56d2523c1f545955f86b98b637b25ef08d03 Mon Sep 17 00:00:00 2001 From: Maxime France-Pillois Date: Fri, 15 Dec 2023 11:12:53 +0000 Subject: [PATCH] Adds warning message to CUDA + removes calls it `die()` in Hip --- source/adapters/cuda/command_buffer.cpp | 10 ++++++++++ source/adapters/hip/command_buffer.cpp | 4 ---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/source/adapters/cuda/command_buffer.cpp b/source/adapters/cuda/command_buffer.cpp index 695ff03ce2..4a3f3da60e 100644 --- a/source/adapters/cuda/command_buffer.cpp +++ b/source/adapters/cuda/command_buffer.cpp @@ -549,6 +549,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMPrefetchExp( // Get sync point and register the cuNode with it. *pSyncPoint = hCommandBuffer->AddSyncPoint(std::make_shared(GraphNode)); + + setErrorMessage("Prefetch hint ignored and replaced with empty node as " + "prefetch is not supported by CUDA Graph backend", + UR_RESULT_SUCCESS); + Result = UR_RESULT_ERROR_ADAPTER_SPECIFIC; } catch (ur_result_t Err) { Result = Err; } @@ -579,6 +584,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMAdviseExp( // Get sync point and register the cuNode with it. *pSyncPoint = hCommandBuffer->AddSyncPoint(std::make_shared(GraphNode)); + + setErrorMessage("Memory advice ignored and replaced with empty node as " + "memory advice is not supported by CUDA Graph backend", + UR_RESULT_SUCCESS); + Result = UR_RESULT_ERROR_ADAPTER_SPECIFIC; } catch (ur_result_t Err) { Result = Err; } diff --git a/source/adapters/hip/command_buffer.cpp b/source/adapters/hip/command_buffer.cpp index c85b3e9216..c7609b6110 100644 --- a/source/adapters/hip/command_buffer.cpp +++ b/source/adapters/hip/command_buffer.cpp @@ -127,8 +127,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMPrefetchExp( ur_usm_migration_flags_t, uint32_t, const ur_exp_command_buffer_sync_point_t *, ur_exp_command_buffer_sync_point_t *) { - detail::ur::die("Experimental Command-buffer feature is not " - "implemented for HIP adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; } @@ -136,8 +134,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMAdviseExp( ur_exp_command_buffer_handle_t, const void *, size_t, ur_usm_advice_flags_t, uint32_t, const ur_exp_command_buffer_sync_point_t *, ur_exp_command_buffer_sync_point_t *) { - detail::ur::die("Experimental Command-buffer feature is not " - "implemented for HIP adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; }