From 10baa78195440d9b878d40f70844b4dba67d44d0 Mon Sep 17 00:00:00 2001 From: PietroGhg Date: Fri, 12 Jan 2024 14:06:47 +0000 Subject: [PATCH 1/4] Empty implementation for command buffer fill --- source/adapters/native_cpu/command_buffer.cpp | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/source/adapters/native_cpu/command_buffer.cpp b/source/adapters/native_cpu/command_buffer.cpp index f13a57f392..6775172eb4 100644 --- a/source/adapters/native_cpu/command_buffer.cpp +++ b/source/adapters/native_cpu/command_buffer.cpp @@ -133,3 +133,26 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferEnqueueExp( "implemented for the NativeCPU adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; } + +UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferFillExp( + ur_exp_command_buffer_handle_t, ur_mem_handle_t, + const void *, size_t, size_t, size_t, + uint32_t, + const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_sync_point_t *) { + detail::ur::die("Experimental Command-buffer feature is not " + "implemented for the NativeCPU adapter."); + return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; +} + +UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMFillExp( + ur_exp_command_buffer_handle_t, + void *, const void *, + size_t, size_t, + uint32_t, + const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_sync_point_t *) { + detail::ur::die("Experimental Command-buffer feature is not " + "implemented for the NativeCPU adapter."); + return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; +} From b0c719927afac593276fe0774cabd9c5111bd628 Mon Sep 17 00:00:00 2001 From: PietroGhg Date: Fri, 12 Jan 2024 14:38:25 +0000 Subject: [PATCH 2/4] formatting --- source/adapters/native_cpu/command_buffer.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/source/adapters/native_cpu/command_buffer.cpp b/source/adapters/native_cpu/command_buffer.cpp index 6775172eb4..48f22f6649 100644 --- a/source/adapters/native_cpu/command_buffer.cpp +++ b/source/adapters/native_cpu/command_buffer.cpp @@ -135,10 +135,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferEnqueueExp( } UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferFillExp( - ur_exp_command_buffer_handle_t, ur_mem_handle_t, - const void *, size_t, size_t, size_t, - uint32_t, - const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_handle_t, ur_mem_handle_t, const void *, size_t, + size_t, size_t, uint32_t, const ur_exp_command_buffer_sync_point_t *, ur_exp_command_buffer_sync_point_t *) { detail::ur::die("Experimental Command-buffer feature is not " "implemented for the NativeCPU adapter."); @@ -146,12 +144,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferFillExp( } UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMFillExp( - ur_exp_command_buffer_handle_t, - void *, const void *, - size_t, size_t, - uint32_t, - const ur_exp_command_buffer_sync_point_t *, - ur_exp_command_buffer_sync_point_t *) { + ur_exp_command_buffer_handle_t, void *, const void *, size_t, size_t, + uint32_t, const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_sync_point_t *) { detail::ur::die("Experimental Command-buffer feature is not " "implemented for the NativeCPU adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; From 8262da98862a68f87debad676be3c99bbeefff17 Mon Sep 17 00:00:00 2001 From: PietroGhg Date: Fri, 12 Jan 2024 16:08:17 +0000 Subject: [PATCH 3/4] Remove calls to std::die in new entry points --- source/adapters/native_cpu/command_buffer.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source/adapters/native_cpu/command_buffer.cpp b/source/adapters/native_cpu/command_buffer.cpp index 48f22f6649..48e4f694bb 100644 --- a/source/adapters/native_cpu/command_buffer.cpp +++ b/source/adapters/native_cpu/command_buffer.cpp @@ -138,8 +138,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferFillExp( ur_exp_command_buffer_handle_t, ur_mem_handle_t, const void *, size_t, size_t, size_t, uint32_t, const ur_exp_command_buffer_sync_point_t *, ur_exp_command_buffer_sync_point_t *) { - detail::ur::die("Experimental Command-buffer feature is not " - "implemented for the NativeCPU adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; } @@ -147,7 +145,5 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMFillExp( ur_exp_command_buffer_handle_t, void *, const void *, size_t, size_t, uint32_t, const ur_exp_command_buffer_sync_point_t *, ur_exp_command_buffer_sync_point_t *) { - detail::ur::die("Experimental Command-buffer feature is not " - "implemented for the NativeCPU adapter."); return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; } From 2bd41d7bdd0d68503b95369f92228cd37b57ef11 Mon Sep 17 00:00:00 2001 From: PietroGhg Date: Fri, 12 Jan 2024 16:08:51 +0000 Subject: [PATCH 4/4] add empty impls for urCommandBufferAppendUSMPrefetchExp and urCommandBufferAppendUSMAdviseExp --- source/adapters/native_cpu/command_buffer.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/source/adapters/native_cpu/command_buffer.cpp b/source/adapters/native_cpu/command_buffer.cpp index 48e4f694bb..50b38c9d52 100644 --- a/source/adapters/native_cpu/command_buffer.cpp +++ b/source/adapters/native_cpu/command_buffer.cpp @@ -147,3 +147,18 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMFillExp( ur_exp_command_buffer_sync_point_t *) { return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; } + +UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMPrefetchExp( + ur_exp_command_buffer_handle_t, const void *, size_t, + ur_usm_migration_flags_t, uint32_t, + const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_sync_point_t *) { + return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; +} + +UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMAdviseExp( + ur_exp_command_buffer_handle_t, const void *, size_t, ur_usm_advice_flags_t, + uint32_t, const ur_exp_command_buffer_sync_point_t *, + ur_exp_command_buffer_sync_point_t *) { + return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; +}