From 9a3141a339ce519b955e97e9b1e1183663b70a76 Mon Sep 17 00:00:00 2001 From: Petr Vesely Date: Thu, 29 Jun 2023 08:46:43 +0100 Subject: [PATCH] [UR][CTS] Add invalid size test to urPhysicalMemCreate --- test/conformance/testing/include/uur/fixtures.h | 2 +- .../virtual_memory/urPhysicalMemCreate.cpp | 14 +++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/test/conformance/testing/include/uur/fixtures.h b/test/conformance/testing/include/uur/fixtures.h index 149239c31b..c3cc85f7a8 100644 --- a/test/conformance/testing/include/uur/fixtures.h +++ b/test/conformance/testing/include/uur/fixtures.h @@ -586,7 +586,7 @@ struct urPhysicalMemTest : urContextTest { ASSERT_NE(physical_mem, nullptr); } - void TearDown() { + void TearDown() override { if (physical_mem) { EXPECT_SUCCESS(urPhysicalMemRelease(physical_mem)); } diff --git a/test/conformance/virtual_memory/urPhysicalMemCreate.cpp b/test/conformance/virtual_memory/urPhysicalMemCreate.cpp index 42396a7999..39059ae0c1 100644 --- a/test/conformance/virtual_memory/urPhysicalMemCreate.cpp +++ b/test/conformance/virtual_memory/urPhysicalMemCreate.cpp @@ -8,7 +8,7 @@ using urPhysicalMemCreateTestParams = size_t; struct urPhysicalMemCreateTest : uur::urContextTestWithParam { - void SetUp() { + void SetUp() override { UUR_RETURN_ON_FATAL_FAILURE(uur::urContextTestWithParam< urPhysicalMemCreateTestParams>::SetUp()); ASSERT_SUCCESS(urVirtualMemGranularityGetInfo( @@ -54,3 +54,15 @@ TEST_P(urPhysicalMemCreateTest, InvalidNullPointerPhysicalMem) { urPhysicalMemCreate(context, device, size, nullptr, nullptr), UR_RESULT_ERROR_INVALID_NULL_POINTER); } + +TEST_P(urPhysicalMemCreateTest, InvalidSize) { + if (granularity == 1) { + GTEST_SKIP() + << "A granularity of 1 means that any size will be accepted."; + } + ur_physical_mem_handle_t physical_mem = nullptr; + size_t invalid_size = size - 1; + ASSERT_EQ_RESULT(urPhysicalMemCreate(context, device, invalid_size, nullptr, + &physical_mem), + UR_RESULT_ERROR_INVALID_SIZE); +}