Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTS tests failing on multi-device scenarios #1063

Closed
jandres742 opened this issue Nov 9, 2023 · 5 comments
Closed

CTS tests failing on multi-device scenarios #1063

jandres742 opened this issue Nov 9, 2023 · 5 comments
Milestone

Comments

@jandres742
Copy link

When running a CTS in a multi-device system, I see errors like:

[ FATAL ]/unified-runtime/build/_deps/googletest-src/googletest/include/gtest/internal/gtest-param-util.h:586::
Condition test_param_names.count(param_name) == 0 failed.
Duplicate parameterized test name 'Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___Intel_R__Data_Center_GPU_Max_1550_', in /unified-runtime/test/conformance/context/urContextCreate.cpp line 10

the problem seem to be here

https://github.com/oneapi-src/unified-runtime/blob/adapters/test/conformance/testing/include/uur/fixtures.h#L97

::testing::ValuesIn(uur::DevicesEnvironment::instance->devices),       \

where the name for tests are created for a set of devices, so if we have multiple devices with the same name, then test aborts.

WA at least for L0- for now is to use ZE_AFFINITY_MASK=0 to select only the first device.

@kbenzie , @pbalcer : are we aware of this? is there a way of fixing it w/o requiring the use of the affinity mask, or in the future, of the ONEAPI_DEVICE_SELECTOR?

@kbenzie
Copy link
Contributor

kbenzie commented Nov 10, 2023

This does remind me of a recent PR, to append the device index to the test name but I'm struggling to find where that was being discussed...

@pbalcer
Copy link
Contributor

pbalcer commented Nov 13, 2023

Yup, that is the problem this PR is trying to fix: #992

@kbenzie
Copy link
Contributor

kbenzie commented Sep 16, 2024

This has probably already been resolved in another PR, will need to check that.

@kbenzie kbenzie added this to the Backlog milestone Sep 16, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Sep 17, 2024

Yes, #1805, we added multi-device PVC testing some time ago and were forced to fix it :)

@kbenzie
Copy link
Contributor

kbenzie commented Sep 17, 2024

Thanks, closing since its already fixed.

@kbenzie kbenzie closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants