Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adapter specific testing #284

Closed
kbenzie opened this issue Feb 20, 2023 · 2 comments
Closed

Enable adapter specific testing #284

kbenzie opened this issue Feb 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request pi DPC++ PI requirement

Comments

@kbenzie
Copy link
Contributor

kbenzie commented Feb 20, 2023

As part of porting PI plugins to UR we also need to enable testing of adapter specific features. The most obvious of these is to test native handles to make sure integration and interop with the underlaying adapter interface is working as expected.

This is gated on adapter code moving into this repository.

  • Determine where the adapter specific code should reside
  • Document this in the readme
  • Implement an example of what this should look like, either with the null adapter or when the first real adapter is moved into this repository.
@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 4, 2023

As discussed here more extensive testing of urPlatformGetLastError is an ideal candidate for adapter specific testing as this relies on knowledge of adapter implementation details in order to actually trigger an adapter specific error so that the message and error code returned from urPlatformGetLastError can be validated.

@veselypeta veselypeta self-assigned this Jul 10, 2023
@veselypeta
Copy link
Contributor

Completed as part of
#790 & #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pi DPC++ PI requirement
Projects
None yet
Development

No branches or pull requests

2 participants