From 877fc5bb65234587c3477c21111873be52b0fcc7 Mon Sep 17 00:00:00 2001 From: Krzysztof Swiecicki Date: Mon, 2 Oct 2023 11:56:38 +0200 Subject: [PATCH] [SYCL][UR][L0] Distinguish min/max calls from macros --- source/adapters/level_zero/command_buffer.cpp | 2 +- source/adapters/level_zero/device.cpp | 4 ++-- source/adapters/level_zero/kernel.cpp | 8 ++++---- source/adapters/level_zero/platform.cpp | 2 +- source/adapters/level_zero/queue.cpp | 8 ++++---- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/source/adapters/level_zero/command_buffer.cpp b/source/adapters/level_zero/command_buffer.cpp index bea22aa417..7ba3cfae4d 100644 --- a/source/adapters/level_zero/command_buffer.cpp +++ b/source/adapters/level_zero/command_buffer.cpp @@ -177,7 +177,7 @@ ur_result_t calculateKernelWorkDimensions( Device->ZeDeviceComputeProperties->maxGroupSizeX, Device->ZeDeviceComputeProperties->maxGroupSizeY, Device->ZeDeviceComputeProperties->maxGroupSizeZ}; - GroupSize[I] = std::min(size_t(GroupSize[I]), GlobalWorkSize[I]); + GroupSize[I] = (std::min)(size_t(GroupSize[I]), GlobalWorkSize[I]); while (GlobalWorkSize[I] % GroupSize[I]) { --GroupSize[I]; } diff --git a/source/adapters/level_zero/device.cpp b/source/adapters/level_zero/device.cpp index e5157fc134..35e48931b2 100644 --- a/source/adapters/level_zero/device.cpp +++ b/source/adapters/level_zero/device.cpp @@ -74,7 +74,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGet( uint32_t ZeDeviceCount = MatchedDevices.size(); - auto N = std::min(ZeDeviceCount, NumEntries); + auto N = (std::min)(ZeDeviceCount, NumEntries); if (Devices) std::copy_n(MatchedDevices.begin(), N, Devices); @@ -1240,7 +1240,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceSelectBinary( uint32_t *SelectedBinaryInd = SelectedBinary; // Find the appropriate device image, fallback to spirv if not found - constexpr uint32_t InvalidInd = std::numeric_limits::max(); + constexpr uint32_t InvalidInd = (std::numeric_limits::max)(); uint32_t Spirv = InvalidInd; for (uint32_t i = 0; i < NumBinaries; ++i) { diff --git a/source/adapters/level_zero/kernel.cpp b/source/adapters/level_zero/kernel.cpp index 266efd9291..dfa8915197 100644 --- a/source/adapters/level_zero/kernel.cpp +++ b/source/adapters/level_zero/kernel.cpp @@ -79,11 +79,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch( UR_RESULT_ERROR_INVALID_VALUE); if (LocalWorkSize) { // L0 - UR_ASSERT(LocalWorkSize[0] < std::numeric_limits::max(), + UR_ASSERT(LocalWorkSize[0] < (std::numeric_limits::max)(), UR_RESULT_ERROR_INVALID_VALUE); - UR_ASSERT(LocalWorkSize[1] < std::numeric_limits::max(), + UR_ASSERT(LocalWorkSize[1] < (std::numeric_limits::max)(), UR_RESULT_ERROR_INVALID_VALUE); - UR_ASSERT(LocalWorkSize[2] < std::numeric_limits::max(), + UR_ASSERT(LocalWorkSize[2] < (std::numeric_limits::max)(), UR_RESULT_ERROR_INVALID_VALUE); WG[0] = static_cast(LocalWorkSize[0]); WG[1] = static_cast(LocalWorkSize[1]); @@ -110,7 +110,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch( Queue->Device->ZeDeviceComputeProperties->maxGroupSizeX, Queue->Device->ZeDeviceComputeProperties->maxGroupSizeY, Queue->Device->ZeDeviceComputeProperties->maxGroupSizeZ}; - GroupSize[I] = std::min(size_t(GroupSize[I]), GlobalWorkSize[I]); + GroupSize[I] = (std::min)(size_t(GroupSize[I]), GlobalWorkSize[I]); while (GlobalWorkSize[I] % GroupSize[I]) { --GroupSize[I]; } diff --git a/source/adapters/level_zero/platform.cpp b/source/adapters/level_zero/platform.cpp index e7944aa3aa..308b6909eb 100644 --- a/source/adapters/level_zero/platform.cpp +++ b/source/adapters/level_zero/platform.cpp @@ -121,7 +121,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urPlatformGet( if (*NumPlatforms == 0) *NumPlatforms = URPlatformsCache->size(); else - *NumPlatforms = std::min(URPlatformsCache->size(), (size_t)NumEntries); + *NumPlatforms = (std::min)(URPlatformsCache->size(), (size_t)NumEntries); } return UR_RESULT_SUCCESS; diff --git a/source/adapters/level_zero/queue.cpp b/source/adapters/level_zero/queue.cpp index 0388b8fdbb..994f595a5d 100755 --- a/source/adapters/level_zero/queue.cpp +++ b/source/adapters/level_zero/queue.cpp @@ -930,8 +930,8 @@ ur_queue_handle_t_::ur_queue_handle_t_( // Set-up to round-robin across allowed range of engines. uint32_t FilterLowerIndex = getRangeOfAllowedComputeEngines().first; uint32_t FilterUpperIndex = getRangeOfAllowedComputeEngines().second; - FilterUpperIndex = std::min((size_t)FilterUpperIndex, - FilterLowerIndex + ComputeQueues.size() - 1); + FilterUpperIndex = (std::min)((size_t)FilterUpperIndex, + FilterLowerIndex + ComputeQueues.size() - 1); if (FilterLowerIndex <= FilterUpperIndex) { ComputeQueueGroup.LowerIndex = FilterLowerIndex; ComputeQueueGroup.UpperIndex = FilterUpperIndex; @@ -959,8 +959,8 @@ ur_queue_handle_t_::ur_queue_handle_t_( } else { uint32_t FilterLowerIndex = Range.first; uint32_t FilterUpperIndex = Range.second; - FilterUpperIndex = std::min((size_t)FilterUpperIndex, - FilterLowerIndex + CopyQueues.size() - 1); + FilterUpperIndex = (std::min)((size_t)FilterUpperIndex, + FilterLowerIndex + CopyQueues.size() - 1); if (FilterLowerIndex <= FilterUpperIndex) { CopyQueueGroup.ZeQueues = CopyQueues; CopyQueueGroup.LowerIndex = FilterLowerIndex;