Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[HIP] Implement ext_oneapi_queue_priority"" #1229

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jan 5, 2024

Reverts #1228

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f14fed) 15.73% compared to head (2c5c237) 15.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   15.73%   15.74%           
=======================================
  Files         223      223           
  Lines       31478    31477    -1     
  Branches     3558     3558           
=======================================
+ Hits         4954     4955    +1     
+ Misses      26473    26472    -1     
+ Partials       51       50    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source/adapters/hip/queue.cpp Outdated Show resolved Hide resolved
source/adapters/hip/queue.cpp Outdated Show resolved Hide resolved
source/adapters/hip/queue.cpp Outdated Show resolved Hide resolved
@kbenzie
Copy link
Contributor Author

kbenzie commented Jan 8, 2024

Thanks @al42and

@kbenzie kbenzie marked this pull request as ready for review January 8, 2024 10:43
@kbenzie kbenzie requested a review from a team as a code owner January 8, 2024 10:43
@kbenzie kbenzie requested a review from npmiller January 8, 2024 10:43
@kbenzie kbenzie merged commit 2d42d77 into main Jan 8, 2024
101 checks passed
@kbenzie kbenzie deleted the revert-1228-revert-984-ext_oneapi_queue_priority-hip branch January 8, 2024 13:40
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Jan 8, 2024
oneapi-src/unified-runtime#1229

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants