Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix kernel execution in fuzztests and run fuzztests on L0 in CI #1427

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Mar 11, 2024

Nightly run: https://github.com/oneapi-src/unified-runtime/actions/runs/9466770778

  • Run fuzztests in CI on Level Zero instead of the Null Adapter
  • Fixes kernel not triggering in fuzztests:
    Failed to open a kernel source file: /home/runner/work/unified-runtime/unified-runtime/build/test/conformance/device_binaries/bar/sycl_spir641.spv
  • Fixes short fuzztests failing to create a device on Level Zero
  • Fuzztests refactoring
  • Enable to input any custom paths to external level zero
  • Build level zero with gcc for fuzztests to avoid crashes when binary finishes
  • Verbose long fuzztests (easier to spot if fuzztests actually get beyond urPlatformGet)

@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 2 times, most recently from 2dcd506 to a442743 Compare March 12, 2024 12:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.51%. Comparing base (78ef1ca) to head (b616445).
Report is 122 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
- Coverage   14.82%   12.51%   -2.32%     
==========================================
  Files         250      239      -11     
  Lines       36220    35949     -271     
  Branches     4094     4076      -18     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31447     +647     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 2 times, most recently from b616445 to aca4913 Compare March 12, 2024 14:54
@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 2 times, most recently from 93618c1 to 3e00b79 Compare March 21, 2024 09:59
@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 3 times, most recently from 1e6b82c to 1782a45 Compare April 4, 2024 13:26
@kbenzie kbenzie added the ci/cd Continuous integration/devliery label Apr 10, 2024
@github-actions github-actions bot added loader Loader related feature/bug level-zero L0 adapter specific issues labels Jun 6, 2024
@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 13 times, most recently from a878c72 to 6424404 Compare June 12, 2024 07:03
@PatKamin PatKamin marked this pull request as ready for review June 12, 2024 07:03
@PatKamin PatKamin requested review from a team as code owners June 12, 2024 07:03
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rebase

.github/workflows/build-fuzz-reusable.yml Outdated Show resolved Hide resolved
test/fuzz/CMakeLists.txt Show resolved Hide resolved
test/fuzz/CMakeLists.txt Show resolved Hide resolved
@PatKamin PatKamin force-pushed the fix-fuzztest-kernel branch 3 times, most recently from 107b5d3 to d29c69b Compare June 13, 2024 08:46
@PatKamin PatKamin requested a review from pbalcer June 14, 2024 06:47
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits.

.github/workflows/build-fuzz-reusable.yml Show resolved Hide resolved
.github/workflows/build-fuzz-reusable.yml Outdated Show resolved Hide resolved
test/fuzz/urFuzz.cpp Show resolved Hide resolved
@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Jun 19, 2024
@kbenzie kbenzie force-pushed the fix-fuzztest-kernel branch 2 times, most recently from a0f94b2 to c841c9a Compare July 2, 2024 10:29
Changes the handling of the UR_LEVEL_ZERO_INCLUDE_DIR environment variable. The user can provide any direct path to the include directory containing level zero headers. No 'level-zero' subdirectory appended to this path anymore.

Note that the path to the include directory has to end with a slash, like ie. "level-zero/include/".
instead of running fuzztests in CI on the null adapter.
- Properly set up and trigger the test kernel within the fuzz test.
- Change the test kernel used from "bar" to "fill".
- Refactor env vars used in test.
@PatKamin
Copy link
Contributor Author

PatKamin commented Jul 4, 2024

Bumped level-zero used by tests to v1.17.6

@kbenzie
Copy link
Contributor

kbenzie commented Jul 4, 2024

Bumped level-zero used by tests to v1.17.6

I wondered if it was something like that, thanks.

@kbenzie kbenzie merged commit fa06e95 into oneapi-src:main Jul 5, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration/devliery level-zero L0 adapter specific issues loader Loader related feature/bug ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants