[HIP] Use context to get active device #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdelan
force-pushed
the
event-wait-with-good-context
branch
from
0223877
to
631e1c1
Compare
npmiller
reviewed
Mar 20, 2024
hdelan
force-pushed
the
event-wait-with-good-context
branch
from
631e1c1
to
5ac438f
Compare
An event made with a native handle will not have an initialized queue. So it is better to get the scoped context device through the context, which is always guaranteed to be initialized.
kbenzie
force-pushed
the
event-wait-with-good-context
branch
from
5ac438f
to
35a6899
Compare
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An event made with a native handle will not have an initialized queue, which the event uses for
ur_event_handle_t::getDevice(). So it is better to get the scoped context device through the context, which is always guaranteed to be initialized.