Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Automatically update ur_structure_type_t #648

Conversation

veselypeta
Copy link
Contributor

Closes #563

@veselypeta veselypeta force-pushed the petr/563/generate-ur-structure-type branch from b992703 to 805fdc7 Compare June 23, 2023 12:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this be new section inside registry.yml rather than a new file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difficulty is that registry.yml is parsed last to ensure that all declared functions have already been parsed. ur_strcture_type_t is referenced directly and thus must be parsed first. The simplest thing was to make it a separate file and parse it first - if there are any new additions that result from parsing the remaining files we then update the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with this is people already get confused when there are conflicts in registry.yml and adding another file that could potentially have conflicts is not a nice workflow.

Could we treat registry.yml specially instead to ensure its read when we need it?

@veselypeta veselypeta force-pushed the petr/563/generate-ur-structure-type branch from 805fdc7 to 7cce66e Compare July 3, 2023 12:41
@veselypeta veselypeta marked this pull request as draft July 3, 2023 12:41
@veselypeta
Copy link
Contributor Author

Closing in favour of #670

@veselypeta veselypeta closed this Jul 4, 2023
@veselypeta veselypeta deleted the petr/563/generate-ur-structure-type branch July 31, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ur] Automatically generate ur_structure_type_t
2 participants