[Exp][Bindless Images] Add BI revision 4 functionality #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
przemektmalon
commented
Jun 27, 2023
przemektmalon
commented
- Added bindless images revision 4 API changes
- Fixed some errors from revision 3
- Added bindless images revision 4 API changes - Fixed some errors from revision 3 Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
veselypeta
approved these changes
Jun 27, 2023
callumfare
approved these changes
Jun 27, 2023
alycm
reviewed
Jun 27, 2023
| BINDLESS_IMAGES_3D_USM_SUPPORT_EXP = 0x2003 ## [::ur_bool_t] returns true if the device supports the creation of 3D | ||
| ## bindless images backed by USM | ||
| IMAGE_PITCH_ALIGN_EXP = 0x2004 ## [uint32_t] returns the required alignment of the pitch between two | ||
| IMAGE_PITCH_ALIGN_EXP = 0x2003 ## [uint32_t] returns the required alignment of the pitch between two |
There was a problem hiding this comment.
Are we okay with these numbers changing because the feature is experimental?
In general can we catch ABI changes like this automatically?
There was a problem hiding this comment.
Obviously this PR is fully of ABI changes, with all the function signature changes. So the enum change is no different to those. Just in general it's easier to miss.
There was a problem hiding this comment.
Experimental features are free to break their own ABI/API - we have some checks to ensure that the core API is unaffected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.