Fix adapter registry test CMake #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `PROJECT_SOURCE_DIR` instead of `CMAKE_SOURCE_DIR` is more resilient as it will still resolve to the base of the unified runtime repository even if used as a sub-project.
veselypeta
approved these changes
Jun 30, 2023
pbalcer
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
PROJECT_SOURCE_DIRinstead ofCMAKE_SOURCE_DIRis more resilient as it will still resolve to the base of the unified runtime repository even if used as a sub-project.I've ran into this issue in my DPC++ build, it's possible my configuration of cache is causing me to hit this when others may not, but it's sensible to replace the CMake variable used here.