Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Test remaining Virtual Memory entry-points #663

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[UR] Test remaining Virtual Memory entry-points #663

merged 1 commit into from
Jul 3, 2023

Conversation

veselypeta
Copy link
Contributor

Relates to #590

@veselypeta veselypeta mentioned this pull request Jun 30, 2023
Closed
10 tasks
@veselypeta veselypeta force-pushed the petr/590/remaining-virtual-mem branch from e9d71ce to b88066d Compare June 30, 2023 11:46
@veselypeta veselypeta force-pushed the petr/590/remaining-virtual-mem branch from b88066d to c9faea7 Compare July 3, 2023 12:00
callumfare
callumfare approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@callumfare callumfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Eventually when (some) adapters implement these entry points it could be useful to have some tests that check the mapped memory can be written to and read from successfully, like we do for urEnqueueMemBufferMap

@veselypeta
Copy link
Contributor Author

LGTM. Eventually when (some) adapters implement these entry points it could be useful to have some tests that check the mapped memory can be written to and read from successfully, like we do for urEnqueueMemBufferMap

#669

@veselypeta veselypeta merged commit 2eae79a into oneapi-src:main Jul 3, 2023
18 checks passed
@veselypeta veselypeta deleted the petr/590/remaining-virtual-mem branch July 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiomestre fabiomestre fabiomestre approved these changes

@callumfare callumfare callumfare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veselypeta @fabiomestre @callumfare