[umf] create/destroy memory tracker in lib ctor/dtor #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
approved these changes
Jul 6, 2023
vinser52
approved these changes
Jul 6, 2023
igchor
force-pushed
the
memory_tracker_dtor
branch
from
2248435
to
362ab31
Compare
instead of relying on global variable init/destruction on linux and on windows (when building UMF as a shared lib). In C++ no guarantee is made for initialization order of static variables across translation units. This is problematic when an application (e.g. SYCL) wants to do some cleanup in it's library destructor. Such application might want to specify priority for it's destructor (to make sure it's executed before any other library desturctor) but it doesn't seem to work for static variables. Memory tracker is still created as a global object when building UMF as a static lib on Windows - there is no __attribute__((destructor)) equivalent that would work for static library.
igchor
force-pushed
the
memory_tracker_dtor
branch
from
362ab31
to
07b7633
Compare
pbalcer
reviewed
Jul 7, 2023
| umf_memory_tracker_handle_t umfMemoryTrackerGet(void) { | ||
| static umf_memory_tracker_t tracker; | ||
| return &tracker; | ||
| #if defined(_WIN32) && defined(UMF_SHARED_LIBRARY) |
There was a problem hiding this comment.
it's fine for now while we have only one global, but eventually we might want to consolidate this somehow and create windows/linux abstractions (like in the loader).
pbalcer
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using a static variable.
In C++ no guarantee is made for initialization order of static variables across translation units.
This is problematic when an application (e.g. SYCL) wants to do some cleanup in it's library destructor. Such application might want to specify priority for it's destructor (to make sure it's executed before any other library desturctor) but it doesn't seem to work for static variables.