[Exp] Added const qualifier to some parameters. #699
Conversation
| @@ -10,10 +10,10 @@ name: ImportExp | |||
| details: | |||
| - "Import memory into USM" | |||
| params: | |||
| - type: $x_context_handle_t | |||
| - type: "const $x_context_handle_t" | |||
There was a problem hiding this comment.
I don't think the context should be const qualified the reason being that an adapter may wish to store data in the context relating to the action being performed in the urUSMImportExp/urUSMExportExp entry points, making this argument const means that becomes impossible. Making this const is also inconsistent with the rest of the API.
There was a problem hiding this comment.
Ok, removed that const on the UR context.
Note that at the SYCL level all USM APIs (such as malloc_device) that take a queue or context parameter declare them const. But its fine to have the underlying context modifiable.
| @@ -30,10 +30,10 @@ name: ReleaseExp | |||
| details: | |||
| - "Release memory from USM" | |||
| params: | |||
| - type: $x_context_handle_t | |||
| - type: "const $x_context_handle_t" | |||
There was a problem hiding this comment.
Also don't think this should be const qualified, see above.
There was a problem hiding this comment.
I'm closing this PR because I don't think these changes are needed. There is a remapping, including casting, between SYCL objects and UR objects anyway.
The context and host pointer parameters now have const qualifier.