Set global compile flags for UR targets only #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
reviewed
Jul 10, 2023
PatKamin
force-pushed
the
wrap-ur-targets
branch
from
e9e7ca4
to
66f2781
Compare
Alternatively, why not wrap I agree, added wrapper functions which adds UR-specific compile flags to targets. |
Leaving sanitizer flags to be set globally. |
kbenzie
approved these changes
Jul 12, 2023
PatKamin
force-pushed
the
wrap-ur-targets
branch
from
66f2781
to
0f8223e
Compare
PatKamin
force-pushed
the
wrap-ur-targets
branch
from
0f8223e
to
360746c
Compare
Currently, some of compile flags are set globally for the whole project including third-party libraries. Introduce wrapper functions for add_executable and add_library CMake functions in order to add compile flags only where needed.
PatKamin
force-pushed
the
wrap-ur-targets
branch
from
360746c
to
0033c6e
Compare
pbalcer
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of compile flags are set globally for the whole project and third-party libraries. Wrap all Unified Runtime CMake targets so that compile and linking flags can be added globally but without affecting third-party repositories' builds.