[Bindless Images][Exp] Add opaque file descriptor handle #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
reviewed
Jul 10, 2023
| @@ -6600,6 +6600,10 @@ typedef struct ur_exp_interop_mem_handle_t_ *ur_exp_interop_mem_handle_t; | |||
| /// @brief Handle of interop semaphore | |||
| typedef struct ur_exp_interop_semaphore_handle_t_ *ur_exp_interop_semaphore_handle_t; | |||
|
|
|||
| /////////////////////////////////////////////////////////////////////////////// | |||
| /// @brief Handle of file descriptor | |||
| typedef struct ur_exp_file_descriptor_handle_t_ *ur_exp_file_descriptor_handle_t; | |||
There was a problem hiding this comment.
so by defining it as handle, each adapter is free to defining as it sees fit, correct?
There was a problem hiding this comment.
Is that the intent? A file handle doesn't really vary per adapter, it varies per host OS.
There was a problem hiding this comment.
@alycm @jandres742 You're both correct.
Leaving the implementation to the adapter allows for flexibility on the implementation, although this would be a crude workaround and less than ideal to label it a handle as this implies a lot more overhead than we want for simple file descriptors.
#704 has been created to discuss and plan support for platform dependent types.
|
Closing in favour of #705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ur_exp_file_descriptor_handle_tto support platform dependent file descriptors.