[ur] Update CTS to match native handle nocheck #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
approved these changes
Jul 17, 2023
kbenzie
force-pushed
the
benie/cts-nocheck-native-events
branch
3 times, most recently
from
e3acf58
to
b24b54f
Compare
Follow up from oneapi-src#720 where the `nocheck` option was added to the `ur_native_handle_t` arguments of `ur<Object>CreateWithNativeHandle`. This patch removes tests which assumed that `ur_native_handle_t` must not be `nullptr` which is an incorrect assumption.
kbenzie
force-pushed
the
benie/cts-nocheck-native-events
branch
from
b24b54f
to
c46db28
Compare
callumfare
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #720 where the
nocheckoption was added to theur_native_handle_targuments ofur<Object>CreateWithNativeHandle.This patch removes tests which assumed that
ur_native_handle_tmustnot be
nullptrwhich is an incorrect assumption.