Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverity issues from 18/07/2023 #730

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fix coverity issues from 18/07/2023 #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ea52c
[coverity] Fix 1566349 Resource leak
kbenzie Jul 18, 2023
19fdd60
[coverity] Fix 1566348 Uninitialized scalar field
kbenzie Jul 18, 2023
38141b3
[coverity] Fix 1566349 Resource leak
kbenzie Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/loader/layers/validation/ur_validation_layer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ namespace ur_validation_layer {
///////////////////////////////////////////////////////////////////////////////
class __urdlllocal context_t : public proxy_layer_context_t {
public:
bool enableParameterValidation;
bool enableLeakChecking;
bool enableParameterValidation = false;
bool enableLeakChecking = false;
logger::Logger logger;

ur_dditable_t urDdiTable = {};
Expand Down
16 changes: 10 additions & 6 deletions test/layers/validation/fixtures.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,24 @@
struct urTest : ::testing::Test {

void SetUp() override {
ur_loader_config_handle_t config;
ASSERT_EQ(urLoaderConfigCreate(&config), UR_RESULT_SUCCESS);
ASSERT_EQ(urLoaderConfigEnableLayer(config, "UR_LAYER_FULL_VALIDATION"),
ASSERT_EQ(urLoaderConfigCreate(&loader_config), UR_RESULT_SUCCESS);
ASSERT_EQ(urLoaderConfigEnableLayer(loader_config,
"UR_LAYER_FULL_VALIDATION"),
UR_RESULT_SUCCESS);

ur_device_init_flags_t device_flags = 0;
ASSERT_EQ(urInit(device_flags, config), UR_RESULT_SUCCESS);
ASSERT_EQ(urLoaderConfigRelease(config), UR_RESULT_SUCCESS);
ASSERT_EQ(urInit(device_flags, loader_config), UR_RESULT_SUCCESS);
ASSERT_EQ(urLoaderConfigRelease(loader_config), UR_RESULT_SUCCESS);
}

void TearDown() override {
if (loader_config) {
ASSERT_EQ(urLoaderConfigRelease(loader_config), UR_RESULT_SUCCESS);
}
ur_tear_down_params_t tear_down_params{};
ASSERT_EQ(urTearDown(&tear_down_params), UR_RESULT_SUCCESS);
}

ur_loader_config_handle_t loader_config = nullptr;
};

struct valPlatformsTest : urTest {
Expand Down
12 changes: 9 additions & 3 deletions test/loader/loader_config/urLoaderConfigCreate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@

#include "fixtures.hpp"

struct LoaderConfigCreateTest : ::testing::Test {};
struct LoaderConfigCreateTest : ::testing::Test {
void TearDown() override {
if (loaderConfig) {
ASSERT_SUCCESS(urLoaderConfigRelease(loaderConfig));
}
}

TEST_F(LoaderConfigCreateTest, Success) {
ur_loader_config_handle_t loaderConfig = nullptr;
};

TEST_F(LoaderConfigCreateTest, Success) {
ASSERT_SUCCESS(urLoaderConfigCreate(&loaderConfig));
ASSERT_SUCCESS(urLoaderConfigRelease(loaderConfig));
}

TEST_F(LoaderConfigCreateTest, InvalidNullPointerLoaderConfig) {
Expand Down