Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ur] Add missing virtual memory support query #737

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/ur.py
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,7 @@ class ur_device_info_v(IntEnum):
IP_VERSION = 113 ## [uint32_t] The device IP version. The meaning of the device IP version
## is implementation-defined, but newer devices should have a higher
## version than older devices.
VIRTUAL_MEMORY_SUPPORT = 114 ## [::ur_bool_t] return true if the device supports virtual memory.
BINDLESS_IMAGES_SUPPORT_EXP = 0x2000 ## [::ur_bool_t] returns true if the device supports the creation of
## bindless images
BINDLESS_IMAGES_SHARED_USM_SUPPORT_EXP = 0x2001 ## [::ur_bool_t] returns true if the device supports the creation of
Expand Down
1 change: 1 addition & 0 deletions include/ur_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -1453,6 +1453,7 @@ typedef enum ur_device_info_t {
UR_DEVICE_INFO_IP_VERSION = 113, ///< [uint32_t] The device IP version. The meaning of the device IP version
///< is implementation-defined, but newer devices should have a higher
///< version than older devices.
UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT = 114, ///< [::ur_bool_t] return true if the device supports virtual memory.
UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP = 0x2000, ///< [::ur_bool_t] returns true if the device supports the creation of
///< bindless images
UR_DEVICE_INFO_BINDLESS_IMAGES_SHARED_USM_SUPPORT_EXP = 0x2001, ///< [::ur_bool_t] returns true if the device supports the creation of
Expand Down
2 changes: 2 additions & 0 deletions scripts/core/device.yml
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,8 @@ etors:
desc: "[uint32_t] The maximum number of registers available per block."
- name: IP_VERSION
desc: "[uint32_t] The device IP version. The meaning of the device IP version is implementation-defined, but newer devices should have a higher version than older devices."
- name: VIRTUAL_MEMORY_SUPPORT
desc: "[$x_bool_t] return true if the device supports virtual memory."
--- #--------------------------------------------------------------------------
type: function
desc: "Retrieves various information about device"
Expand Down
18 changes: 18 additions & 0 deletions source/common/ur_params.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2768,6 +2768,10 @@ inline std::ostream &operator<<(std::ostream &os, enum ur_device_info_t value) {
os << "UR_DEVICE_INFO_IP_VERSION";
break;

case UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT:
os << "UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT";
break;

case UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP:
os << "UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP";
break;
Expand Down Expand Up @@ -4392,6 +4396,20 @@ inline void serializeTagged(std::ostream &os, const void *ptr,
os << ")";
} break;

case UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT: {
const ur_bool_t *tptr = (const ur_bool_t *)ptr;
if (sizeof(ur_bool_t) > size) {
os << "invalid size (is: " << size
<< ", expected: >=" << sizeof(ur_bool_t) << ")";
return;
}
os << (void *)(tptr) << " (";

os << *tptr;

os << ")";
} break;

case UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP: {
const ur_bool_t *tptr = (const ur_bool_t *)ptr;
if (sizeof(ur_bool_t) > size) {
Expand Down
3 changes: 2 additions & 1 deletion test/conformance/device/urDeviceGetInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ INSTANTIATE_TEST_SUITE_P(
UR_DEVICE_INFO_ASYNC_BARRIER, //
UR_DEVICE_INFO_MEM_CHANNEL_SUPPORT, //
UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED, //
UR_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP //
UR_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP, //
UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT //
),
[](const ::testing::TestParamInfo<ur_device_info_t> &info) {
std::stringstream ss;
Expand Down