-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAPTERS] update to latest from sycl #759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UR] Add documentation to experimental feature support
…GetInfo [UR][CTS] Add urMemImageGetInfo tests and missing spec return values
[UR] Device CTS fixes
…elsetargpointer [UR][CTS] Fix urKernelSetArgPointer tests
- Added bindless images revision 4 API changes - Fixed some errors from revision 3 Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
…-revision-4 [Exp][Bindless Images] Add BI revision 4 functionality
Memory provider: Remove the get_last_result function and replace it with get_last_error. This primary difference is the addition of the pError out parameter which returns a native error code emitted from a failed provider function which resulted in returning UMA_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC. Memory_pool: Remove the get_last_result function and replace it with get_last_allocation_status. For memory pool, I don't think we care about a pool-specific error codes. We do, however, want to know why the previous allocation/de-allocation failed. Memory pool allocation functions only return a pointer so we need an extra function (get_last_allocation_status) to get this information.
use get_last_allocation_error to return last error from allocation functions.
…-cts-tempalte [UR] Setup Virtual Memory CTS template
by returning the name directly instead of through out param. This function is not allowed to fail anyway.
which returns handle to the last failed provider. This makes error reporting API independent from how memory pool is using the providers (i.e. whether there is only a single provider or multiple)
[UR] Install DPCXX
…emGranularityGetInfo [UR][CTS] Adds CTS coverage for urVirtualMemGranularityGetInfo
[uma] Improve reporting of pool/provider specific errors
…image-readwrite [UR][CTS] Add urEnqueueMemImageRead/Write tests
to avoid confusion with uniform memory access.
Using `PROJECT_SOURCE_DIR` instead of `CMAKE_SOURCE_DIR` is more resilient as it will still resolve to the base of the unified runtime repository even if used as a sub-project.
[uma] rename uma to umf
Fix adapter registry test CMake
…cInit Correct ur_usm_desc_t initialization in USM alloc conformance tests.
[UMA] add more tests for allocations
[umf] fix the last remaining coverity issue
This adds a new CMake option 'UMF_ENABLE_POOL_TRACKING' that enables pool tracking in UMF. Pool tracking is turned off by default. The pool tracking tests were wrapped around the compile definition 'UMF_ENABLE_POOL_TRACKING_TESTS'.
[umf] Make pool tracking optional
Fix shadowing in USM pool test fixture, correct assertion in PoolRetain test.
- memory leak in memory_pool_default.c and tests - allocating memory with alignemnt=8 and size%8 != 0
Add ThreadSanitizer option
[umf] fix erors reported by ASAN
to make ASAN happy. By default we are using alignment == 8 and size needs to be a multiple of that. We might consider adding extra tests, specifically for different sizes.
This image can be used in CI or as a development container.
[umf] use alloc sizes that are multiples of 8 in tests
Add first Docker image recipe
Add security compiler and linker flags
that appeared on intel/llvm CI
[ur] fix ctad-maybe-unsupported warning
I also tried adding the |
kbenzie
approved these changes
Aug 1, 2023
pbalcer
force-pushed
the
adapters-update
branch
from
August 2, 2023 09:02
f76b729
to
759e753
Compare
veselypeta
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no nightly tag yet that contains the latest UR update on the SYCL side, so I'm creating this as draft with
web/sycl-latest-good
tag.