Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAPTERS] update to latest from sycl #759

Merged
merged 178 commits into from
Aug 2, 2023

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Aug 1, 2023

There's no nightly tag yet that contains the latest UR update on the SYCL side, so I'm creating this as draft with web/sycl-latest-good tag.

Petr Vesely and others added 30 commits June 23, 2023 14:14
[UR] Add documentation to experimental feature support
…GetInfo

[UR][CTS] Add urMemImageGetInfo tests and missing spec return values
…elsetargpointer

[UR][CTS] Fix urKernelSetArgPointer tests
- Added bindless images revision 4 API changes
- Fixed some errors from revision 3

Co-authored-by: Isaac Ault <isaac.ault@codeplay.com>
Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
…-revision-4

[Exp][Bindless Images] Add BI revision 4 functionality
Memory provider:
 Remove the get_last_result function and replace it with
 get_last_error. This primary difference is the addition of
 the pError out parameter which returns a native error code
 emitted from a failed provider function which resulted in returning
 UMA_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC.

Memory_pool:
 Remove the get_last_result function and replace it with
 get_last_allocation_status. For memory pool, I don't think we care
 about a pool-specific error codes. We do, however, want to know why the
 previous allocation/de-allocation failed. Memory pool allocation
 functions only return a pointer so we need an extra function
 (get_last_allocation_status) to get this information.
use get_last_allocation_error to return last error
from allocation functions.
…-cts-tempalte

[UR] Setup Virtual Memory CTS template
by returning the name directly instead of through out param. This
function is not allowed to fail anyway.
which returns handle to the last failed provider.

This makes error reporting API independent from how
memory pool is using the providers (i.e. whether there is
only a single provider or multiple)
…emGranularityGetInfo

[UR][CTS] Adds CTS coverage for urVirtualMemGranularityGetInfo
[uma] Improve reporting of pool/provider specific errors
…image-readwrite

[UR][CTS] Add urEnqueueMemImageRead/Write tests
to avoid confusion with uniform memory access.
Using `PROJECT_SOURCE_DIR` instead of `CMAKE_SOURCE_DIR` is more
resilient as it will still resolve to the base of the unified runtime
repository even if used as a sub-project.
pbalcer and others added 23 commits July 25, 2023 10:49
…cInit

Correct ur_usm_desc_t initialization in USM alloc conformance tests.
[umf] fix the last remaining coverity issue
This adds a new CMake option 'UMF_ENABLE_POOL_TRACKING' that
enables pool tracking in UMF. Pool tracking is turned off by
default.
The pool tracking tests were wrapped around the compile definition
'UMF_ENABLE_POOL_TRACKING_TESTS'.
Fix shadowing in USM pool test fixture, correct assertion in PoolRetain test.
- memory leak in memory_pool_default.c and tests
- allocating memory with alignemnt=8 and size%8 != 0
[umf] fix erors reported by ASAN
to make ASAN happy. By default we are using alignment
== 8 and size needs to be a multiple of that.

We might consider adding extra tests, specifically for
different sizes.
This image can be used in CI or as a development container.
[umf] use alloc sizes that are multiples of 8 in tests
Add security compiler and linker flags
that appeared on intel/llvm CI
@pbalcer
Copy link
Contributor Author

pbalcer commented Aug 1, 2023

I also tried adding the native_cpu backend, but it still has non-trivial dependencies to SYCL.

@pbalcer pbalcer marked this pull request as ready for review August 2, 2023 09:02
@pbalcer pbalcer merged commit fb05463 into oneapi-src:adapters Aug 2, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.