Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make urInit and urTearDown loader-only #793

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Make urInit and urTearDown loader-only #793

merged 1 commit into from
Aug 28, 2023

Conversation

callumfare
Copy link
Contributor

  • Make urInit and urTeardown loader-only, rename them to urLoaderInit and urLoaderTearDown
  • Split runtime.yml into loader.yml and adapter.yml
  • Add teardown method to layers so they can still cleanly tidy up any state, as they will no longer intercept the loader-only urLoaderTearDown.
  • Correct the validation layer's tracking of adapter handles, as urAdapterGet may either create the initial reference or increment it.
  • Track the number of in-use adapters in the validation layer. When no more adapters are in use, report all leaked handles. This allows reporting of leaks even if a user does not call urLoaderTeardown

veselypeta
veselypeta approved these changes Aug 9, 2023
View reviewed changes
scripts/parse_specs.py Outdated Show resolved Hide resolved
pbalcer
pbalcer reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being targeted for the upcoming release, so 0.7.1 (or something like that)?

examples/collector/collector.cpp Show resolved Hide resolved
@pbalcer pbalcer requested a review from kswiecicki August 9, 2023 12:52
aarongreig
aarongreig approved these changes Aug 9, 2023
View reviewed changes
source/loader/ur_lib.cpp Outdated Show resolved Hide resolved
kswiecicki
kswiecicki reviewed Aug 9, 2023
View reviewed changes
scripts/core/CONTRIB.rst Show resolved Hide resolved
scripts/core/loader.yml Outdated Show resolved Hide resolved
@callumfare callumfare force-pushed the callum/loader_init branch 4 times, most recently from 7f696db to fa1a3e4 Compare August 10, 2023 12:50
@kbenzie
Copy link
Contributor

kbenzie commented Aug 16, 2023 •
edited
Loading

Is this being targeted for the upcoming release, so 0.7.1 (or something like that)?

I don't think so, its too big a change for 2024.0 which 0.7.x is primarily for.

I've opened #806 to discuss defining a release process.

kbenzie
kbenzie approved these changes Aug 25, 2023
View reviewed changes
scripts/core/adapter.yml Outdated Show resolved Hide resolved
test/loader/platforms/null_platform.match Outdated Show resolved Hide resolved
@callumfare callumfare force-pushed the callum/loader_init branch 2 times, most recently from 3619f1e to 5114b57 Compare August 25, 2023 15:54
@callumfare
Copy link
Contributor Author

Assuming this passes CI this should be ready to merge now - not sure if we're waiting for anything else before that happens

@pbalcer pbalcer merged commit f7682a2 into oneapi-src:main Aug 28, 2023
28 checks passed
This was referenced Sep 12, 2023
Closed
Closed
@0x12CC 0x12CC mentioned this pull request Sep 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswiecicki kswiecicki kswiecicki left review comments

@kbenzie kbenzie kbenzie approved these changes

@pbalcer pbalcer pbalcer approved these changes

@aarongreig aarongreig aarongreig approved these changes

@veselypeta veselypeta veselypeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@callumfare @kbenzie @pbalcer @aarongreig @veselypeta @kswiecicki