[OpenCL] Add more mappings from CL error codes to UR error codes. #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also merge urQueueCreate InvalidValueProperties test into InvalidQueueProperties test.
aarongreig
force-pushed
the
aaron/clErrorCodeMapping
branch
from
494aef2
to
2792092
Compare
|
Looks like this is now passing in the CUDA adapter. Need to update the match file. |
kbenzie
approved these changes
Oct 20, 2023
|
@aarongreig there does not appear to be an https://github.com/intel/llvm PR for this as per the Adapter Change Process |
|
forgot to do that before I went on holiday, is it worth doing now? this is technically a cts fix so it could wait to go in with the rest of them |
Okay, we can test it in the combined branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also merge urQueueCreate InvalidValueProperties test into InvalidQueueProperties test.