Use add_umf_library() instead of add_ur_library() #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Use_add_umf_library_instead_of_add_ur_library
branch
from
be94a1a
to
5d419d6
Compare
add_ur_library() is undefined in UMF now, because it is defined only in the UR project. Define and use add_umf_library() instead of add_ur_library(), so that UMF can be used as a stand-alone project. Fixes: oneapi-src#981 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Use_add_umf_library_instead_of_add_ur_library
branch
from
5d419d6
to
6e2dbba
Compare
bratpiorka
approved these changes
Oct 20, 2023
|
It will be fixed in the new UMF repo: https://github.com/oneapi-src/unified-memory-framework |
|
It is already fixed in the new UMF repo: https://github.com/oneapi-src/unified-memory-framework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_ur_library()is undefined in UMF now,because it is defined only in the UR project.
Define and use
add_umf_library()instead ofadd_ur_library(),so that UMF can be used as a stand-alone project.
Fixes: #981