Eliminate whole file chunks #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with unblob-handlers in different configurations and it works as expected. I'd leave the review to either @vlaci or @martonilles 😎 |
e3krisztian
force-pushed
the
eliminate_whole_file_chunks
branch
2 times, most recently
from
b459170
to
9d2e90d
Compare
|
We have had a conversation about this and the current branch removes also intermediate extracted files which should be kept. We just want to skip the carving, but not the extraction part. Probably it would make sense to separate more explicitly the carve and extract phases. |
e3krisztian
force-pushed
the
eliminate_whole_file_chunks
branch
2 times, most recently
from
97e70d4
to
92f7b55
Compare
vlaci
reviewed
Apr 1, 2022
e3krisztian
force-pushed
the
eliminate_whole_file_chunks
branch
from
92f7b55
to
cd27a9d
Compare
martonilles
requested changes
Apr 3, 2022
e3krisztian
force-pushed
the
eliminate_whole_file_chunks
branch
2 times, most recently
from
dae1a1d
to
4ccda47
Compare
This is done with the below script and looking through the resulting git change.
$ cat recreate_outputs.sh
#!/bin/bash
set -e
cd tests/integration
find -name __output__ | xargs rm -rf
find -name __input__ |
while read input; do
(
cd "$input"
mkdir ../__output__
cd ../__output__
find ../__input__ -type f |
while read fw; do
unblob --keep-extracted-chunks "$fw"
done
)
done
# empty, but extracted directories
find -type d | rg __output__ |
while read dir; do
rmdir --ignore-fail-on-non-empty "$dir"
if [ ! -d "$dir" ]; then
mkdir "$dir"
touch "$dir/.gitkeep"
fi
done
git add .
e3krisztian
force-pushed
the
eliminate_whole_file_chunks
branch
from
4ccda47
to
3b5f2d0
Compare
martonilles
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #303