Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression in fcl.tx(txId).onceSealed() #2045

Closed
jasonatmagic opened this issue Dec 15, 2024 · 1 comment · Fixed by #2046
Closed

[BUG] Regression in fcl.tx(txId).onceSealed() #2045

jasonatmagic opened this issue Dec 15, 2024 · 1 comment · Fixed by #2046
Labels
Bug Something isn't working

Comments

@jasonatmagic
Copy link

jasonatmagic commented Dec 15, 2024

Current Behavior

onceSealed() no longer return/resolve after the transaction completes
await fcl.tx(response).onceSealed();

Expected Behavior

the transaction should resolve properly

Steps To Reproduce

error introduced by this commit b9f4949
with "suppress" logic separated from original error condition, anytime suppressed is not being set, (ie: suppress=false), the subsequent predicate(txStatus) check will never get triggered regardless of the error situation, causing "resolve" never getting triggered

Environment

error seen in "@onflow/fcl-core": "1.13.0" onward. no error in "1.12.0"

What are you currently working on that this is blocking?

No response

@jasonatmagic jasonatmagic added the Bug Something isn't working label Dec 15, 2024
@jribbink jribbink moved this to 🏗 In Progress in 🌊 Flow 4D Dec 15, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in 🌊 Flow 4D Dec 16, 2024
@jribbink jribbink changed the title [BUG] <title> [BUG] Regression in fcl.tx(txId).onceSealed() Dec 16, 2024
@jribbink
Copy link
Contributor

Hey @jasonatmagic , thanks for submitting the bug report. This issue has been resolved in @onflow/fcl@1.13.3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants