Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put assertions and post-conditions in the generic transactions #162

Open
joshuahannan opened this issue May 20, 2024 · 0 comments · May be fixed by #166
Open

Put assertions and post-conditions in the generic transactions #162

joshuahannan opened this issue May 20, 2024 · 0 comments · May be fixed by #166
Assignees
Labels
enhancement New feature or request Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt

Comments

@joshuahannan
Copy link
Member

joshuahannan commented May 20, 2024

Issue To Be Solved

If we are going to encourage projects to use the generic token transactions, we should add assertions and/or post-conditions to them to make sure that they are behaving properly.

Transactions in Question

Suggest A Solution

Add these conditions:

  • Make sure the withdrawn tokens are the same type that is defined by the specified contract
  • Make sure it has the correct balance
  • Think of others
@joshuahannan joshuahannan added enhancement New feature or request Feedback Technical Debt SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels May 20, 2024
@joshuahannan joshuahannan self-assigned this May 20, 2024
@joshuahannan joshuahannan linked a pull request Jul 9, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

1 participant